-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane: Quadplane: rework assistance check #26318
Conversation
0dce872
to
61347ac
Compare
Added logging of the various states to the QTUN message, the existing assist uint8 becomes a flags bitmask, so no increase in log size. |
4694399
to
f836967
Compare
Rebased and updated assist autotest to check alt assist and transition fail action. |
f836967
to
ee5220d
Compare
To see what it might look like the last commit moves the assist functionality into new files. |
I like the concept, but needs a bunch of testing |
…ngle get clear delay
54f0615
to
91e1a85
Compare
Rebased. |
Tested all types of assist with Alti Transition in realflight. All working as expected. Log here: https://drive.google.com/file/d/1sLEzbqd3NTciKZ3HMAg2rtyuZozzm02N/view?usp=sharing |
This reworks the assistance check into a new sub class. There are also a number of functional changes:
in_alt_assist
andalt_error_start_ms
are not cleared.This will need a fair bit of testing, so far it has had none. I have opened the PR so we can get consensus on the desired behavior.
We might also want to re-work the messages, currently you can get a alt assisting message while still in speed assistance, we might want the messages to behave as before, so as soon as the speed is reached the alt assistance message is given. However it is quite nice to get the message early, it saves attempting the transition only to reach your set speed and find your too low.
We might also want to re-issue the angle and alt assistance warnings periodically.
A followup PR could move all these functions into a new file,
quadplane.cpp
it is getting big....